sfeed

commit 9d96397cef3d75f2af96b7a31bf2aef910346b0c
parent 6ce5f1e755eb81bc89bc0fa5d5650173e3f697b1
Author: Hiltjo Posthuma <hiltjo@codemadness.org>
Date:   Thu, 23 Aug 2018 19:11:52 +0200

xml: remove TODO comments and add a note

Diffstat:
M
xml.c
 | 
7
++++---

1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/xml.c b/xml.c
@@ -350,8 +350,9 @@ xml_parse(XMLParser *x)
 
 			if (c == '!') { /* cdata and comments */
 				for (tagdatalen = 0; (c = x->getnext()) != EOF;) {
-					if (tagdatalen <= sizeof("[CDATA[") - 1) /* if (d < sizeof(x->data)) */
-						x->data[tagdatalen++] = c; /* TODO: prevent overflow */
+					/* NOTE: sizeof(x->data) must be atleast sizeof("[CDATA[") */
+					if (tagdatalen <= sizeof("[CDATA[") - 1)
+						x->data[tagdatalen++] = c;
 					if (c == '>')
 						break;
 					else if (c == '-' && tagdatalen == sizeof("--") - 1 &&
@@ -381,7 +382,7 @@ xml_parse(XMLParser *x)
 				x->isshorttag = ispi;
 				taglen = 1;
 				while ((c = x->getnext()) != EOF) {
-					if (c == '/') /* TODO: simplify short tag? */
+					if (c == '/')
 						x->isshorttag = 1; /* short tag */
 					else if (c == '>' || isspace(c)) {
 						x->tag[taglen] = '\0';