From 78cdbdf01dfca7700db07caec49067eb44b09721 Mon Sep 17 00:00:00 2001 From: Louis Burda Date: Mon, 13 Mar 2023 12:59:36 +0100 Subject: Prevent memory leak when realloc fails --- src/bitvec.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/bitvec.c b/src/bitvec.c index 1015c26..72bb23d 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -73,17 +73,19 @@ bitvec_free(struct bitvec *vec) bool bitvec_reserve(struct bitvec *vec, size_t cnt) { + void *alloc; + LIBBITVEC_ASSERT(vec != NULL); cnt = BITCEIL(cnt); if (vec->cap >= cnt) return true; - vec->data = realloc(vec->data, SLOTCNT(cnt) * SLOT_BYTES); - if (!vec->data) { + alloc = realloc(vec->data, SLOTCNT(cnt) * SLOT_BYTES); + if (!alloc) { LIBBITVEC_HANDLE_ERR("realloc"); return false; } - + alloc = vec->data; memset(vec->data + SLOT(vec->cap), 0, SLOT(cnt) - SLOT(vec->cap)); vec->cap = cnt; @@ -93,17 +95,18 @@ bitvec_reserve(struct bitvec *vec, size_t cnt) bool bitvec_shrink(struct bitvec *vec, size_t cnt) { + void *alloc; LIBBITVEC_ASSERT(vec != NULL); cnt = BITCEIL(cnt); if (vec->cap <= cnt) return true; - vec->data = realloc(vec->data, SLOTCNT(cnt)); - if (!vec->data) { + alloc = realloc(vec->data, SLOTCNT(cnt)); + if (!alloc) { LIBBITVEC_HANDLE_ERR("realloc"); return false; } - + vec->data = alloc; vec->cap = cnt; return true; -- cgit v1.2.3-71-gd317