diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-01-23 07:30:38 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-24 22:15:15 -0800 |
| commit | 217962615662f1ab7a60978a194444023039f0a4 (patch) | |
| tree | a8442084adcf6c415841a8a6a9a6591b7defaa88 /include/linux/debugobjects.h | |
| parent | a016becd3a56cdb260013c8fe1d4aefc6edc4989 (diff) | |
| download | cachepc-linux-217962615662f1ab7a60978a194444023039f0a4.tar.gz cachepc-linux-217962615662f1ab7a60978a194444023039f0a4.zip | |
net: phy: warn if phy_start is called from invalid state
phy_start() should be called from states PHY_READY or PHY_HALTED only.
Check for this to detect misbehaving drivers. Also the state machine
should be started only when being called from one of the valid states.
Some more background:
For all invalid states phy_start() basically was a no-op. All it did
was triggering a state machine run, but for all "running" states the
poll loop was active anyway. And if called from PHY_DOWN, the state
machine does nothing.
v3:
- extended commit message
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/debugobjects.h')
0 files changed, 0 insertions, 0 deletions