summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtlwifi
Commit message (Collapse)AuthorAgeFilesLines
* staging: rtlwifi: move remaining phydm .h filesGreg Kroah-Hartman2019-05-012-75/+0
| | | | | | | | | The rtl8188eu driver uses the phydm .h files from the rtlwifi driver, but now that the rtlwifi driver is gone, it's silly to have a whole directory for just 2 .h files. So move these files into the rtl8188eu driver's directory so that it can be self-contained. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: strip down phydm .h filesGreg Kroah-Hartman2019-05-012-269/+2
| | | | | | | | The phydm .h files are used by another driver, but not all of the defines are used, so strip them down to their basic necessities before we move them out of this directory. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: delete the staging driverGreg Kroah-Hartman2019-05-01179-123318/+0
| | | | | | | | | | | | | | | | | | A "real" driver for this hardware is now in the wireless-drivers-next tree, to be merged in the next major kernel release, so this staging driver can now be deleted as it is not needed anymore. Note, 2 .h files remain for this driver, as they are referenced in a separate staging driver. That mess will be cleaned up in a follow-on patch. Cc: Ping-Ke Shih <pkshih@realtek.com> Cc: Tzu-En Huang <tehuang@realtek.com> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> Cc: Stanislaw Gruszka <sgruszka@redhat.com> Cc: Brian Norris <briannorris@chromium.org> Cc: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtlwifi: Replace return typeMadhumitha Prabakaran2019-04-201-3/+1
| | | | | | | | | Replace return type and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: fix spelling mistake "notity" -> "notify"Colin Ian King2019-04-191-2/+2
| | | | | | | | There are two spelling mistake in RT_TRACE messages. Fix them. Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtlwifi: Cleanup crc16_ccitt()Madhumitha Prabakaran2019-04-161-7/+7
| | | | | | | | | | | | crc16_ccitt() function does "BIT(0) << i" instead of "BIT(i)". Using !! is slightly shorter than "foo ? 1: 0" and remove unnecessary parentheses to make the code simple. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtlwifi: Remove & on function nameMadhumitha Prabakaran2019-04-161-2/+2
| | | | | | | | | Function name is otherwise used as pointers without &. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: base: Remove set but not used variablesYueHaibing2019-04-161-14/+4
| | | | | | | | | | | | | | | | | | | | | | | | Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/base.c: In function 'rtl_tx_agg_stop': drivers/staging/rtlwifi/base.c:1733:23: warning: variable 'tid_data' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/base.c: In function 'rtl_check_beacon_key': drivers/staging/rtlwifi/base.c:2474:5: warning: variable 'ds_param_len' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/base.c:2472:5: warning: variable 'ht_oper_len' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/base.c:2470:5: warning: variable 'ht_cap_len' set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: rtl8822be: Remove set but not used variable 'curtxbw_40mhz'YueHaibing2019-04-161-7/+2
| | | | | | | | | | | | | | Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/rtl8822be/hw.c: In function 'rtl8822be_update_hal_rate_mask': drivers/staging/rtlwifi/rtl8822be/hw.c:2144:5: warning: variable 'curtxbw_40mhz' set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: add missing SPDX lines to Makefile filesGreg Kroah-Hartman2019-04-033-0/+3
| | | | | | | | | There are a few remaining drivers/staging/*/Makefile files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: add missing SPDX lines to Kconfig filesGreg Kroah-Hartman2019-04-031-0/+1
| | | | | | | | There are a few remaining drivers/staging/*/Kconfig files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: base.c: Replace bit shifting with BIT macroPayal Kshirsagar2019-04-021-1/+1
| | | | | | | | | Challenge suggested by coccinelle. Prefer using BIT and replace bit shifting with the BIT(x) macro and remove cast. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: rtl8822be: Remove functionsNishka Dasgupta2019-04-022-16/+0
| | | | | | | | | Remove functions _rtl8822be_set_fw_ps_rf_on and rtl8822be_fw_clk_off_timer_callback as they do not appear in the results of `git grep` and the driver can be compiled without them. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: use !x in place of NULL comparisonPayal Kshirsagar2019-04-011-1/+1
| | | | | | | | Challenge suggested by coccinelle. Avoid NULL comparison, compare using boolean operator. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: halmac: halmac_api.c: Compress two lines into one linePayal Kshirsagar2019-04-011-5/+2
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: halmac: Compress two lines into one linePayal Kshirsagar2019-04-011-4/+1
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: halmac: halmac_88xx: Compress two lines into one linePayal Kshirsagar2019-04-011-4/+1
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: btcoexist: Compress two lines into one linePayal Kshirsagar2019-04-011-4/+1
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: phydm: phydm_rainfo.c: Compress two lines into one linePayal Kshirsagar2019-04-011-4/+1
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variable. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: phydm: phydm.c: Compress two lines into one linePayal Kshirsagar2019-04-011-12/+4
| | | | | | | | Challenge suggested by coccinelle. Compresses two lines into one line and remove unnecessary variables. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: phydm: Move function arguments to previous lineNishka Dasgupta2019-04-011-4/+2
| | | | | | | | Move function arguments to previous line to solve Checkpatch warning "Line should not end with a '('". Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: phydm: Move operator to left hand sideNishka Dasgupta2019-04-011-4/+2
| | | | | | | | Simplify expressions from `status = status & <expression>` to `status &= <expression>` to make the code more readable. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge 5.1-rc3 into staging-nextGreg Kroah-Hartman2019-04-012-0/+4
|\ | | | | | | | | | | We want those fixes and this resolves an erofs merge conflict. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtlwifi: Fix potential NULL pointer dereference of kzallocAditya Pakki2019-03-211-0/+2
| | | | | | | | | | | | | | | | | | | | phydm.internal is allocated using kzalloc which is used multiple times without a check for NULL pointer. This patch avoids such a scenario by returning 0, consistent with the failure case. Signed-off-by: Aditya Pakki <pakki001@umn.edu> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtlwifi: rtl8822b: fix to avoid potential NULL pointer dereferenceAditya Pakki2019-03-211-0/+2
| | | | | | | | | | | | | | | | | | | | skb allocated via dev_alloc_skb can fail and return a NULL pointer. This patch avoids such a scenario and returns, consistent with other invocations. Signed-off-by: Aditya Pakki <pakki001@umn.edu> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: phydm: Remove parenthesesNishka Dasgupta2019-03-301-5/+5
| | | | | | | | | | | | | | | | Remove parentheses on right hand side of expression. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: Remove unnecessary parenthesesPayal Kshirsagar2019-03-301-1/+1
| | | | | | | | | | | | | | | | | | Challenge suggested by coccinelle. Remove unnecessary parentheses around the right hand side of an assignment. Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: phydm: phydm_adc_sampling.c Remove bracketsNishka Dasgupta2019-03-291-2/+2
| | | | | | | | | | | | | | | | Remove parentheses around right hand side of expression. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: phydm: phydm_hwconfig.c: Remove parenthesesNishka Dasgupta2019-03-291-8/+8
| | | | | | | | | | | | | | | | Remove parentheses around right hand side of expression. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: Remove return variable.Sanjana Sanikommu2019-03-291-11/+4
| | | | | | | | | | | | | | | | Remove return variable and return "return" value directly. Issue found by Coccinelle using ret.cocci. Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: Replace 0 with false.Bhagyashri Dighole2019-03-181-1/+1
| | | | | | | | | | | | | | | | | | Replace 0 with false, Bool intializations should use true or false. Detected by Coccinelle semantic patch boolinit.cocci. Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: rtlwifi: phydm: remove unnecessary parenthesesHimadri Pandya2019-03-182-2/+2
|/ | | | | | | | Remove unnecessary parentheses around the right hand side of assignment operator. Issue found using Coccinelle. Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xxNathan Chancellor2019-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | | Clang warns: drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11: warning: implicit conversion from enumeration type 'enum halmac_cmd_process_status' to different enumeration type 'enum halmac_ret_status' [-Wenum-conversion] return HALMAC_CMD_PROCESS_ERROR; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Fix this by using the proper enum for allocation failures, HALMAC_RET_MALLOC_FAIL, which is used in the rest of this file. Fixes: e4b08e16b7d9 ("staging: r8822be: check kzalloc return or bail") Link: https://github.com/ClangBuiltLinux/linux/issues/375 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Remove set but not used variables 'dataempty, hoffset'YueHaibing2019-02-191-4/+2
| | | | | | | | | | | | | | | | | Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/efuse.c: In function 'efuse_pg_packet_write': drivers/staging/rtlwifi/efuse.c:922:24: warning: variable 'dataempty' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/efuse.c: In function 'efuse_get_current_size': drivers/staging/rtlwifi/efuse.c:1185:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] They're never used and can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: fix spelling mistake: "Hightest" -> "Highest"Colin Ian King2019-02-191-1/+1
| | | | | | | Trivial fix to spelling mistake in ODM_RT_TRACE message text, fix it. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: r8822be: check kzalloc return or bailNicholas Mc Guire2019-02-191-1/+4
| | | | | | | | | | The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL so check the psd_set->data after allocation and if allocation failed return HALMAC_CMD_PROCESS_ERROR. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-drive") Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: replace ---help--- with help in KconfigCezary Kierzyk2019-01-301-1/+1
| | | | | | | | | This patch fixes the checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Cezary Kierzyk <virdipravum.n008d3v@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* drivers: staging: rtlwifi: Start statement on a tabstopFelipe Cardoso Resende2019-01-301-1/+2
| | | | | | | | | | Fix the following checkpatch.pl warning: WARNING: Statements should start on a tabstop #208: FILE: pci.h:208: + /*ASPM*/ u8 const_pci_aspm; Signed-off-by: Felipe Cardoso Resende <felipecardoso.fcr@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: rtl8822b: fix a missing check of alloc_skbKangjie Lu2019-01-151-0/+2
| | | | | | | | | __netdev_alloc_skb() return NULl when it fails. skb_put() further uses it even when the allocation fails, leading to NULL pointer dereference. The fix inserts a check for the return value of __netdev_alloc_skb(). Signed-off-by: Kangjie Lu <kjlu@umn.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: fix spelling mistake "disnabled" -> "disabled"Colin Ian King2018-12-051-1/+1
| | | | | | | There is a spelling mistake in an ODM_RT_TRACE message, fix it. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rb8822be Change line not to end with '('Ricardo Silva2018-11-271-3/+3
| | | | | | | | | | To comply with checkpatch. CHECK: Lines should not end with a '(' +u8 rtl_mrate_idx_to_arfr_id( Signed-off-by: Ricardo Silva <ricsilvs1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Add new line to stay in 80 charactersCristian Sicilia2018-11-201-1/+2
| | | | | | | | The parameter is sent to next line to stay in 80 characters Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Add spaces to match open parenthesisCristian Sicilia2018-11-201-2/+2
| | | | | | | | Added before parameters some spaces to match open parenthesis on previous line. Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Add spaces for commentsMaya Nakamura2018-11-082-2/+2
| | | | | | | Add spaces before and after text in comments. Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Remove empty commentMaya Nakamura2018-11-081-1/+0
| | | | | | | Remove a comment that does not contain any text. Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Improve line endingsMaya Nakamura2018-11-082-5/+6
| | | | | | | | Edit statements so that the line does not end with an assignment operator or a parenthesis. Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: SET_RATE_ID inline no arg reuseCristian Sicilia2018-11-071-27/+37
| | | | | | | | | | | The macro SET_RATE_ID is a definition in function and undefined at end of function. Make it as inline avoid the arg reuse for macro, the name is changed in _rtl_rate_id, following the same function pattern in the file. Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Modified the line ending with a parenthesisCristian Sicilia2018-11-071-4/+3
| | | | | | | | This patch fixes two line ending with parenthesis, which did not conform to the linux kernel coding style. Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* drivers: staging: rtl*: fix spelling mistake "Orginial" -> "Original"Colin Ian King2018-11-071-4/+4
| | | | | | | Trivial fix to common spelling mistakes in some rtl* drivers Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtlwifi: Keep expressions on one lineMaya Nakamura2018-11-052-5/+3
| | | | | | | | Edit two statements to keep expressions on one line--one from Julia's feedback. Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-71-gd317 (git 2.46.0) at 2026-01-11 10:12:59 +0000