enowars5-service-stldoctor

commit edd8a25cb8b469d8649e83fbbedac9a6ae87b521
parent bcb8884e6fb74b6d3e3c234caa8ffec7be005ecf
Author: Louis Burda <quent.burda@gmail.com>
Date:   Wed, 19 May 2021 20:42:54 +0200

added patches for fixing each flagstore

Diffstat:
A
service/src/patches/flagstore1.diff
 | 
19
+++++++++++++++++++
A
service/src/patches/flagstore2.diff
 | 
13
+++++++++++++

2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/service/src/patches/flagstore1.diff b/service/src/patches/flagstore1.diff
@@ -0,0 +1,19 @@
+diff --git a/service/src/util.c b/service/src/util.c
+index 31a2628..354bbca 100644
+--- a/service/src/util.c
++++ b/service/src/util.c
+@@ -78,13 +78,12 @@ void
+ freadstr(FILE *f, char **dst)
+ {
+ 	size_t start, len, tmp;
+-	char c;
+ 
+ 	/* VULN #1: BAD CAST */
+ 	/* see documentation/README.md for more details */
+ 
+ 	start = ftell(f);
+-	for (len = 0; (c = fgetc(f)) != EOF && c; len++);
++	for (len = 0; fgetc(f) > 0; len++);
+ 	fseek(f, start, SEEK_SET);
+ 
+ 	*dst = checkp(calloc(1, len + 1));
diff --git a/service/src/patches/flagstore2.diff b/service/src/patches/flagstore2.diff
@@ -0,0 +1,13 @@
+diff --git a/service/src/util.c b/service/src/util.c
+index 31a2628..bf272db 100644
+--- a/service/src/util.c
++++ b/service/src/util.c
+@@ -58,7 +58,7 @@ mhash(const char *str, int len)
+ 	srand(v);
+ 
+ 	for (bp = buf, i = 0; i < MHASHLEN / 2; i++)
+-		bp += sprintf(bp, "%02x", str[i % len] ^ (rand() % 256));
++		bp += sprintf(bp, "%02x", (unsigned char) str[i % len] ^ (rand() % 256));
+ 
+ 	return buf;
+ }